T2D-319 spring rest docs #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskir
reviewed
Jul 11, 2019
There was a problem hiding this comment.
I think the REST API documentation is reasonable. The only thing I'd like to comment on (which is not directly related to this PR) is that this repository lacks the general description on what the property registry is and how it stacks with the other AMP T2D components. I think it would be nice to add it
|
yes, I just provided an example of rest docs, so that we can evaluate how it looks like and whether should we go with it. If we decide to go with it we can definitely add it. |
tskir
approved these changes
Jul 15, 2019
cyenyxe
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.