EVA-3664 Update test to throw exception in transaction when saving new block #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitin-ebi
force-pushed
the
exception-in-transaction
branch
from
c499e6a
to
b90a93d
Compare
tcezard
approved these changes
Oct 9, 2024
pom.xml
Outdated
| @@ -28,7 +28,7 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <junit.version>4.13</junit.version> | |||
| <variation-commons-version>0.8.5</variation-commons-version> | |||
| <accession-commons-version>0.7.16</accession-commons-version> | |||
| <accession-commons-version>0.7.17-SNAPSHOT</accession-commons-version> | |||
apriltuesday
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the test to throw an exception while trying to reserve a new block, forcing the code to retry. This is currently failing as it tries to use the same transaction once it succeeds after a few retries.
This test case should start passing once we pull in the changes done in accession commons to create a new transaction for every retry.