EVA-3639 File stats job #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
reviewed
Aug 23, 2024
| private static final String KEY_NO_OF_PASS = "nPass"; | ||
| private static final String KEY_NO_OF_TRANSITION = "nTi"; | ||
| private static final String KEY_NO_OF_TRANSVERSION = "nTv"; | ||
| private static final String KEY_NO_OF_MEANQ = "meanQ"; |
There was a problem hiding this comment.
Suggested change
| private static final String KEY_NO_OF_MEANQ = "meanQ"; | |
| private static final String KEY_MEANQ = "meanQ"; |
tcezard
reviewed
Aug 23, 2024
| if (isSNV) { | ||
| String ref = variantDocument.getReference(); | ||
| String alt = variantDocument.getAlternate(); | ||
| Set<String> transitions = new HashSet<>(Arrays.asList("AG", "GA", "CT", "TC")); |
There was a problem hiding this comment.
Shouldn't this be put as a class variable ?
There was a problem hiding this comment.
Yes, this should be a constant. Updated.
tcezard
approved these changes
Aug 27, 2024
apriltuesday
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.