Skip to content

Commit

Permalink
fix upload
Browse files Browse the repository at this point in the history
  • Loading branch information
apriltuesday committed Mar 12, 2024
1 parent 56561b6 commit f11a3e9
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions eva_sub_cli/submit.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env python
import os
from urllib.parse import urljoin

import requests
from ebi_eva_common_pyutils.config import WritableConfig
Expand All @@ -15,7 +14,7 @@
SUB_CLI_CONFIG_KEY_SUBMISSION_UPLOAD_URL = "submission_upload_url"
SUB_CLI_CONFIG_KEY_COMPLETE = "submission_complete"

SUBMISSION_WS_URL = "https://www.ebi.ac.uk/eva/webservices/submission-ws/submission/"
SUBMISSION_WS_URL = "https://www.ebi.ac.uk/eva/webservices/submission-ws/v1/"


class StudySubmitter(AppLogger):
Expand Down Expand Up @@ -51,11 +50,11 @@ def _get_submission_ws_url(self):

@property
def submission_initiate_url(self):
return self._get_submission_ws_url() + 'submission/initiate'
return os.path.join(self._get_submission_ws_url(), 'submission/initiate')

@property
def submission_uploaded_url(self):
return self._get_submission_ws_url() + 'submission/{submissionId}/uploaded'
return os.path.join(self._get_submission_ws_url(), 'submission/{submissionId}/uploaded')

def update_config_with_submission_id_and_upload_url(self, submission_id, upload_url):
self.sub_config.set(SUB_CLI_CONFIG_KEY_SUBMISSION_ID, value=submission_id)
Expand All @@ -76,7 +75,7 @@ def _upload_submission(self):
def _upload_file(self, submission_upload_url, input_file):
base_name = os.path.basename(input_file)
self.debug(f'Transfer {base_name} to EVA FTP')
r = requests.put(urljoin(submission_upload_url, base_name), data=open(input_file, 'rb'))
r = requests.put(os.path.join(submission_upload_url, base_name), data=open(input_file, 'rb'))
r.raise_for_status()
self.debug(f'Upload of {base_name} completed')

Expand Down

0 comments on commit f11a3e9

Please sign in to comment.