Skip to content

Commit

Permalink
HDF5 1.14.3: Skip amrex.fpe_trap_invalid
Browse files Browse the repository at this point in the history
  • Loading branch information
ax3l committed Sep 6, 2024
1 parent 161ead7 commit 6b1e735
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
6 changes: 5 additions & 1 deletion .azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ pr:
jobs:
- job:
variables:
AMREX_CMAKE_FLAGS: -DAMReX_ASSERTIONS=ON -DAMReX_TESTING=ON -DpyAMReX_IPO=OFF
# TODO: fpe_trap_invalid broken in HDF5 1.14.3
# Remove "-DWarpX_TEST_FPETRAP_ARGS=..." once 1.14.4 is available.
# https://github.com/HDFGroup/hdf5/issues/4801
# https://github.com/conda-forge/hdf5-feedstock/pull/231
AMREX_CMAKE_FLAGS: -DAMReX_ASSERTIONS=ON -DAMReX_TESTING=ON -DpyAMReX_IPO=OFF -DWarpX_TEST_FPETRAP_ARGS=amrex.fpe_trap_overflow=1 amrex.fpe_trap_zero=1"
CMAKE_BUILD_PARALLEL_LEVEL: 2
CMAKE_GENERATOR: Ninja
CXXFLAGS: -Wno-array-bounds # many false positives in g++ 12
Expand Down
8 changes: 8 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,15 @@ mark_as_advanced(WarpX_TEST_CLEANUP)

# Advanced option to run CI tests with FPE-trapping runtime parameters
option(WarpX_TEST_FPETRAP "Run CI tests with FPE-trapping runtime parameters" OFF)
set(WarpX_TEST_FPETRAP_ARGS
"amrex.fpe_trap_invalid = 1"
"amrex.fpe_trap_overflow = 1"
"amrex.fpe_trap_zero = 1"
CACHE STRING
"AMReX FPE-trapping runtime options if(WarpX_TEST_FPETRAP)"
)
mark_as_advanced(WarpX_TEST_FPETRAP)
mark_as_advanced(WarpX_TEST_FPETRAP_ARGS)

set(WarpX_DIMS_VALUES 1 2 3 RZ)
set(WarpX_DIMS 3 CACHE STRING "Simulation dimensionality <1;2;3;RZ>")
Expand Down
6 changes: 1 addition & 5 deletions Examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,7 @@ function(add_warpx_test
)
set(runtime_params_fpetrap "")
if(WarpX_TEST_FPETRAP)
set(runtime_params_fpetrap
"amrex.fpe_trap_invalid = 1"
"amrex.fpe_trap_overflow = 1"
"amrex.fpe_trap_zero = 1"
)
set(runtime_params_fpetrap ${WarpX_TEST_FPETRAP_ARGS})
endif()
add_test(
NAME ${name}.run
Expand Down

0 comments on commit 6b1e735

Please sign in to comment.