-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature projection div cleaner #4944
Merged
roelof-groenewald
merged 89 commits into
ECP-WarpX:development
from
clarkse:add_feature_projection_div_cleaner
Aug 29, 2024
Merged
Add feature projection div cleaner #4944
roelof-groenewald
merged 89 commits into
ECP-WarpX:development
from
clarkse:add_feature_projection_div_cleaner
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
clarkse
added
enhancement
New feature or request
component: initialization
Changes related to the initialization of the simulation
labels
May 22, 2024
…se/WarpX into add_feature_projection_div_cleaner
for more information, see https://pre-commit.ci
…se/WarpX into add_feature_projection_div_cleaner
This was
linked to
issues
May 23, 2024
for more information, see https://pre-commit.ci
…se/WarpX into add_feature_projection_div_cleaner
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Roelof Groenewald <[email protected]>
…o be after grid_type is initialized.
…d for Yee algorithm.
for more information, see https://pre-commit.ci
Co-authored-by: Roelof Groenewald <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
changing to execute callback at finest level when loading external fields so all levels are accessible
…r. Updated failing test benchmarks. Adding input parameters to control tolerance on command line or through python.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: S. Eric Clark <[email protected]>
roelof-groenewald
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding this! Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: initialization
Changes related to the initialization of the simulation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divergence cleaner class that computes the divergence at cell centers, then uses that as a source for a Poisson solve using MLMG that can be used to remove divergence components from the B-fields after initialization. This is useful for scrubbing interpolated B fields that are loaded into WarpX either through the openPMD loader or when using the pyWarpX fields interface.