-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strang implicit spectral em redo #5027
Open
dpgrote
wants to merge
14
commits into
ECP-WarpX:development
Choose a base branch
from
dpgrote:add_StrangImplicitSpectralEM_redo
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add strang implicit spectral em redo #5027
dpgrote
wants to merge
14
commits into
ECP-WarpX:development
from
dpgrote:add_StrangImplicitSpectralEM_redo
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/** | ||
* \brief Time-biasing parameter for fields used on RHS to advance system | ||
*/ | ||
amrex::Real m_theta = 0.5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dpgrote Is m_theta used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed references to theta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: implicit solvers
Anything related to implicit solvers
component: spectral
Spectral solvers (PSATD, IGF)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements use of the PSATD field advance coupled with the implicit solver, using a Strang split advance.
This requires the input parameter psatd.update_with_rho = 0.
With psatd.periodic_single_box_fft = 1, exact energy conservation is obtained. Otherwise good conservation is seen, but not exact (will depend on parameters).
Convergence is found for wpedt <= 1.9 (compared to wpedt < 0.25 for FDTD).
This PR replaces PR #4662.
A task for a future PR would be to implement specialized source free spectral advance routines (as noted in source comments).