ES solver cleanup - 2024 hackathon #5241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class ES and derived ExplicitES
roelof-groenewald
added
hackathon
…X into es_solver_cleanup
roelof-groenewald
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: roelof-groenewald <[email protected]>
RemiLehe
reviewed
Sep 13, 2024
RemiLehe
reviewed
Sep 13, 2024
RemiLehe
reviewed
Sep 13, 2024
Remi's suggestion Co-authored-by: Remi Lehe <[email protected]>
Co-authored-by: Remi Lehe <[email protected]>
RemiLehe
reviewed
Sep 13, 2024
RemiLehe
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls various pieces of code associated with the electrostatic solver out of
WarpXand organizes it into a new sub-module ofFieldSolverscalledElectrostaticSolvers.Team members: @aeriforme @RevathiJambunathan @roelof-groenewald