Fix the time for the insulator boundary field evaluation #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the timing correct in ThetaImplicitEM.cpp Update variable names to be more precise in the time notation
EZoni
reviewed
Dec 6, 2024
EZoni
reviewed
Dec 6, 2024
EZoni
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Could you confirm that these changes in the checksums are expected? In particular, do you know which call(s) specifically were using the wrong time value and were thus fixed in this PR, leading to these changes in the checksums?
There was a problem hiding this comment.
These changes were expected. Previously, in each call to EvolveB the time used when setting the boundary conditions was the start of the time step. With this PR, the time is the correct time, at the half time step and end time step for the split calls to EvolveB in the explicit solver.
EZoni
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the application of the insulator boundary conditions, the field in the insulator is specified using an expression that can be a function of time. This PR updates the calls to that routine to pass in the correct time, for example the time at the half step or the end of the step. This requires passing the time down the call chain to the routines that apply the insulator boundaries which makes this a fairly sizable set of changes.
Note that in some places the variable names were changed to be more precise about which time is passed in. For example, using
start_timewhenever the time at the start of the step is expected.