Add dispersion to reduced diagnostics #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Correct number of particle to match analysis script.
Correct number of particles in the Python input.
Remove unused ParmParse values from input.
Remove unused ParmParse values from input.
for more information, see https://pre-commit.ci
Relaxing the tolerance of the reduced diagnostics slightly.
Relaxing tolerance again. Some of the reduced Twiss values are rather sensitive to noise.
|
All tests currently pass except Windows. Windows test fails because of trouble opening |
ax3l
reviewed
Aug 19, 2024
MPI/no-MPI and no extra file
for more information, see https://pre-commit.ci
cemitch99
commented
Aug 19, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Axel Huebl <[email protected]>
|
@cemitch99 oh, we forgot to update the documentation in https://impactx.readthedocs.io/en/latest/dataanalysis/dataanalysis.html#reduced-beam-characteristics |
|
Added in #686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the reduced beam diagnostics to include beam-based dispersion values
dispersion_x,dispersion_yand their derivativesdispersion_px,dispersion_py. Close #678.The transverse Twiss functions
beta_x,beta_y,alpha_x,alpha_ywere modified to account for correlations with energy in a dispersive beamline.