-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dispersion to reduced diagnostics #682
Add dispersion to reduced diagnostics #682
Conversation
for more information, see https://pre-commit.ci
Correct number of particle to match analysis script.
Correct number of particles in the Python input.
Remove unused ParmParse values from input.
Remove unused ParmParse values from input.
for more information, see https://pre-commit.ci
Relaxing the tolerance of the reduced diagnostics slightly.
Relaxing tolerance again. Some of the reduced Twiss values are rather sensitive to noise.
All tests currently pass except Windows. Windows test fails because of trouble opening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The non-MPI test fails because of the pattern matching of the CSV file (only one .N
at the end).
We can avoid the CSV file altogether and read directly from the openPMD file we have open like this:
MPI/no-MPI and no extra file
for more information, see https://pre-commit.ci
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Axel Huebl <[email protected]>
@cemitch99 oh, we forgot to update the documentation in https://impactx.readthedocs.io/en/latest/dataanalysis/dataanalysis.html#reduced-beam-characteristics |
Added in #686 |
Modified the reduced beam diagnostics to include beam-based dispersion values
dispersion_x
,dispersion_y
and their derivativesdispersion_px
,dispersion_py
. Close #678.The transverse Twiss functions
beta_x
,beta_y
,alpha_x
,alpha_y
were modified to account for correlations with energy in a dispersive beamline.