[2251] Fix FDevID Update Paths #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rixxan
added
bug
Linux
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that could occur when non-installer distributions running in locations where the running users can't write to couldn't pull and update their FDEVID files. This alters the system to write to the same general location as the Plugins folder is located, as well as run the fdevid updater on startup.
This also adapts the function to accept a "local" argument to try and force the program to update the files at the same location as the program itself, such as for builds or for backward compatibility (although backward compatibility with the FDEVID files has never been guaranteed).
Also adds a sanity check to the addcommodity function just as a quick safety net.
Type of Change
Fix
How Tested
Tested with the EDCD Discord including several Linux developers who pointed out this issue.
Notes
Closes #2251.