[2256] Allow Variable Num of Variables #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 5.11.1, a handover occurred from the older/out of date infi.systray to a more updated fork, simplesystray. This worked for the most part, however, a few edge cases showed this fork was not as drop-in a replacement as we were lead to believe.
This fixes the issue (reported in #2256) by allowing the open_window() function to accept any number of variables, with a minimum of 1. This works with both infi.systray and simplesystray logic.
Type of Change
Bugfix
How Tested
Tested with various iterations of minimize to tray and on both infi and simple systray.
Notes
Closes #2256.