[748] Allow Custom Plugins Directory #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rixxan
added
enhancement
Plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the ability for users to customize their plugin directory away from the default directory's "plugins" folder. This allows users to swap between multiple different plugin "profiles". This does require a restart, so also adds an ability for EDMC to forcefully shut down and restart itself.
Additionally, this updates the post_args callback to not force the settings window to be half-rendered during the callback. This is done by performing two callback operations at various stages with different payloads. While this is slightly duplicative, the impact is negligible. The loading of the Windows config also happens sooner in the program start-up, simply to allow the config to load the new customizable location sooner. This key is created at runtime if it does not exist.
Images
Type of Change
Enhancement
How Tested
Tested with various builds and configuration points on Windows builds. Linux has not yet been tested.
Notes
Resolves #748