add check for localhost in learningEnabled function

EFForg · Oct 3, 2020 · 06fc1e9 · 06fc1e9
1 parent 45a12f9
commit 06fc1e9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/js/incognito.js b/src/js/incognito.js
@@ -25,7 +25,7 @@ function startListeners() {
   chrome.tabs.onRemoved.addListener(onRemovedListener);
 }
 
-function learningEnabled(tab_id) {
+function learningEnabled(tab_id, tab_host) {
   if (badger.getSettings().getItem("learnInIncognito")) {
     // treat all pages as if they're not incognito
     return true;
@@ -35,6 +35,10 @@ function learningEnabled(tab_id) {
   if (!tabs.hasOwnProperty(tab_id)) {
     return false;
   }
+  // if tab host is a localhost or any private domain, default to disabled
+  if (window.isPrivateDomain(tab_host)) {
+    return false;
+  }
   // else, do not learn in incognito tabs
   return !tabs[tab_id];
 }