Show better info when no 3rd party resources present.

[cowlicks]

closes #1625 #1211

related to #1443

before

Previously on a page with no 3rd party resources, we saw:

And for an extension pages, or a page with no tabId in tabData

:

after

The popup now looks like this on websites with no 3rd party resources, and for pages with not tabId in tabData:

[eenblam]

Fails on a test that tries to follow the "trackers" link. This link no longer appears when visiting eff.org, as "There are no third party resources on this site." is presented instead.

privacybadger/tests/selenium/popup_test.py

Line 124 in 9889237

trackers_link = self.driver.find_element_by_link_text("trackers")

[cowlicks]

@eenblam thank you for looking in to this. I'll fix that test case. And add another one that tests this new functionality explicitly.

[cowlicks]

Updated to fix the broken test, and add a test.

We didn't have a nice way to load the PB popup for a given tab, so I used some of the functionality @lemnis added (reference: #1516 (comment) ) to add a utility to do this. This code is 660bf60 1773272 and db8fa81

I use this utility to add a selenium testing utility in 6748aee

Fix the broken test in 507fb

Then add a test for the functionality this PR adds in f633157

Note there is a similar function in tests/selenium/cookie_test.py but it has bugs so I didn't use it here. I'll make a separate issue to replace it with this code.

[cowlicks]

@eenblam I fixed the broken tests. How does it look to you?

[eenblam]

The following assertion will never reach a failure state. Here, WebDriverWait is called without any exception handling, so it will raise selenium.common.exceptions.TimeoutException if the two urls do not equal each other before the timeout. So, the test will fail here, and we won't get the nice message from the assertion below.

[cowlicks]

Yeah, I know :(

I did this to avoid using an explicit wait like time.sleep(2). I guess I could put this whole part in a try/except and fail with the message in the except.