Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around broken Italian locale popup in Chrome #2006

Merged
merged 1 commit into from
May 10, 2018
Merged

Work around broken Italian locale popup in Chrome #2006

merged 1 commit into from
May 10, 2018

Conversation

ghostwords
Copy link
Member

By reverting the CSS padding change from bc231ec.

Fixes #1977.

Could you please check Android is still OK?

@ghostwords
Work around broken Italian locale popup in Chrome.
fa1cf47 
By reverting CSS padding change.
@ghostwords ghostwords requested a review from bcyphers May 7, 2018 16:27
bcyphers
bcyphers approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@bcyphers bcyphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in chrome, ff, and android. In Firefox, there is still an issue where the popup has both an inner scroll bar (for the tracker list) and an outer scroll bar (for the whole thing), but I believe that's out of the scope of this PR.

@ghostwords
Copy link
Member Author

Thanks! Yep, that's #1077.

@ghostwords ghostwords merged commit fa1cf47 into master May 10, 2018
ghostwords added a commit that referenced this pull request May 10, 2018
@ghostwords
Merge pull request #2006.
e21a271 
Work around Chrome rendering bug in the the Italian locale popup.
@ghostwords ghostwords deleted the fix-italian-popup-in-chrome branch May 10, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcyphers bcyphers bcyphers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostwords @bcyphers