Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timing issue in Cloudflare migration #2537

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Conversation

ghostwords
Copy link
Member

This bug results in inadvertently removing pre-trained data for some new users.

Follows up on #2536. Related to #2438.

This bug results in removing pre-trained data for some new users.
Copy link
Contributor

@ablanathtanalba ablanathtanalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

ghostwords added a commit that referenced this pull request Jan 10, 2020
Fix timing bug in Cloudflare migration. The bug sometimes removes
pre-trained data for new Privacy Badger users.
@ghostwords ghostwords merged commit 36b6e11 into master Jan 10, 2020
@ghostwords ghostwords deleted the fix-cloudflare-migration branch January 10, 2020 16:42
@ghostwords ghostwords added the migrations Badger user data modifications label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrations Badger user data modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants