Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suggested changes to DMCC community-specific instructions #508

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Add suggested changes to DMCC community-specific instructions #508

merged 3 commits into from
Oct 3, 2022

Conversation

sebastian-luna-valero
Copy link
Member

Summary

Related issue :

@sebastian-luna-valero sebastian-luna-valero added the safe for preview Pull request vetted as safe for preview label Sep 14, 2022
@github-actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/508

@sebastian-luna-valero
Copy link
Member Author

@gwarf regarding the error below:

ERROR: 1 dead links found!
[✖] ../../../providers/cloud-compute/openstack/vo_config/ → Status: 400

Any suggestions?
Thanks!

@gwarf
Copy link
Member

gwarf commented Sep 14, 2022 •
edited
Loading

@gwarf regarding the error below:

ERROR: 1 dead links found!
[✖] ../../../providers/cloud-compute/openstack/vo_config/ → Status: 400

Any suggestions? Thanks!

Unfortunately there is nothing we can do, those "false" errors are due to how things are organised in the cloud-compute section (ie. not having sections with a dedicated folder and an _index.md).
The solution may be to look for fixing markdown-link-check upstream...

So we have to ignore them for now, and rely on our manual checks.

See also #294.

@sebastian-luna-valero
Copy link
Member Author

Thanks @gwarf

Let's then ignore it for now.

@sebastian-luna-valero
Copy link
Member Author

@glarocca could you please review https://docs.egi.eu/documentation/508/users/communities/dmcc/

and let me know your opinion?

I have fixed the broken links and linked existing tutorials, as requested.

Thanks!

gwarf
gwarf approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/508

@gwarf gwarf merged commit f980b44 into main Oct 3, 2022
@gwarf gwarf deleted the training-dmcc branch October 3, 2022 14:04
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwarf gwarf gwarf approved these changes

@enolfc enolfc Awaiting requested review from enolfc enolfc is a code owner

@glarocca glarocca Awaiting requested review from glarocca glarocca is a code owner

@andrea-manzi andrea-manzi Awaiting requested review from andrea-manzi andrea-manzi is a code owner

@thebe14 thebe14 Awaiting requested review from thebe14

Assignees
No one assigned
Labels
safe for preview Pull request vetted as safe for preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastian-luna-valero @gwarf