Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about the VO property #618

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Add information about the VO property #618

merged 4 commits into from
Nov 14, 2023

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Oct 17, 2023 •
edited
Loading

Summary

Document the use of the VO property so discovery can properly work with cloud-info-provider

Related issue :

@enolfc enolfc added the safe for preview Pull request vetted as safe for preview label Oct 17, 2023
@github-actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/618

gwarf
gwarf approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/618

@gwarf
Copy link
Member

gwarf commented Oct 24, 2023

@CatalinCondurache , please have a look

@sebastian-luna-valero
Copy link
Member

Shall we promote egi_VO instead as discussed in the FedCloud slack channel?

@sebastian-luna-valero
Copy link
Member

On the meeting on 24th Oct 2023 it was decided (and tested) to use egi.VO

@enolfc
Copy link
Contributor Author

enolfc commented Oct 24, 2023

On the meeting on 24th Oct 2023 it was decided (and tested) to use egi.VO

yes needs update

sebastian-luna-valero
sebastian-luna-valero requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the property name from VO to egi.VO as agreed with fedcloud providers in the fedcloud task force meeting on 24th Oct 2023.

content/en/providers/cloud-compute/openstack/vo_config.md Outdated Show resolved Hide resolved
content/en/providers/cloud-compute/openstack/vo_config.md Outdated Show resolved Hide resolved
content/en/providers/cloud-compute/openstack/vo_config.md Outdated Show resolved Hide resolved
@enolfc @sebastian-luna-valero
Apply suggestions from code review
af8a852 
Co-authored-by: Sebastian Luna-Valero <[email protected]>
@github-actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/618

@enolfc
Copy link
Contributor Author

enolfc commented Oct 24, 2023

@CatalinCondurache can you check this one?

CatalinCondurache
CatalinCondurache approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@CatalinCondurache CatalinCondurache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/618

@gwarf
Copy link
Member

gwarf commented Nov 14, 2023

Thanks, @CatalinCondurache.
@sebastian-luna-valero the merge is blocked by your request for changes, can you please check/confirm all is OK?

@gwarf gwarf merged commit b6b1cee into EGI-Federation:main Nov 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwarf gwarf gwarf approved these changes

@sebastian-luna-valero sebastian-luna-valero sebastian-luna-valero approved these changes

@CatalinCondurache CatalinCondurache CatalinCondurache approved these changes

Assignees

@CatalinCondurache CatalinCondurache

Labels
safe for preview Pull request vetted as safe for preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enolfc @gwarf @sebastian-luna-valero @CatalinCondurache