Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pre-commit hooks and prettier config #636

Merged
merged 8 commits into from
Feb 26, 2024

Conversation

brucellino
Copy link
Member

@brucellino brucellino commented Feb 24, 2024

Summary

This adds pre-commit hooks and a few configuration files for enforcing style guides.

Specific hooks are:

  1. prettier -- format code before it's committed to respect the language standard it's written in.
  2. check-jsonschema -- ensure that Github Action workflows respect the schema
  3. markdown-link-check -- check links on changed markdown files

Related issue : #635 #157

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@glarocca glarocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastian-luna-valero
Copy link
Member

Good to see this @brucellino!

Could you please update https://docs.egi.eu/about/contributing/git/#run-the-site-locally as well?

Many thanks!

This comment has been minimized.

Signed-off-by: Bruce Becker <[email protected]>

This comment has been minimized.

This comment has been minimized.

@brucellino
Copy link
Member Author

@sebastian-luna-valero done.

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enolfc
Copy link
Contributor

enolfc commented Feb 26, 2024

@brucellino can you fix the super linter errors?

@enolfc enolfc merged commit 37c9af9 into EGI-Federation:main Feb 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants