Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new TCS ACME GEANTOV ACME endpoint #660

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Use new TCS ACME GEANTOV ACME endpoint #660

merged 2 commits into from
Jun 13, 2024

Conversation

gwarf
Copy link
Member

@gwarf gwarf commented Jun 12, 2024

Use new TCS ACME GEANTOV ACME endpoint

@gwarf gwarf requested a review from paolini78 as a code owner June 12, 2024 17:28

This comment has been minimized.

@gwarf

This comment has been minimized.

Copy link

⌛ check-spelling changes applied

As configured, the commit pushed by @check-spelling-bot to GitHub doesn't trigger GitHub workflows due to a limitation of the @github-actions system.

Users with the Admin role can address this for future interactions 🪄

Create a deploy key and secret

(
  set -e
  brand=check-spelling; repo='EGI-Federation/documentation'; SECRET_NAME=CHECK_SPELLING
  cd "$(mktemp -d)"
  ssh-keygen -f "./$brand" -q -N "" -C "$brand key for $repo"
  gh repo deploy-key add "./$brand.pub" -R "$repo" -w -t "$brand-talk-to-bot"
  gh secret -R "$repo" set "$SECRET_NAME" < "./$brand"
)

Configure update job in workflow to use secret

If the .github/workflows/spelling.yml workflow Update PR job doesn't already have the check-spelling/with/ssh_key, then add them:

    name: Update PR
    ...
    steps:
    ...
    - name: apply spelling updates
      uses: ${action_ref:-check-spelling/check-spelling@...}
      with:
        checkout: true
+       ssh_key: "${{ secrets.CHECK_SPELLING }}"

To trigger another validation round and hopefully a ✅, please add a blank line, e.g. to .github/actions/spelling/expect.txt and commit the change.

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwarf
Copy link
Member Author

gwarf commented Jun 13, 2024

So it seems that for some reason the CI/CD wasn't triggered/running, not sure if it's due to this special flow...
In fact there is some stuff here:
https://github.com/EGI-Federation/documentation/actions/runs/9495479440

@gwarf
Copy link
Member Author

gwarf commented Jun 13, 2024

The Check-spelling job was skipped, so there is no reporting

Copy link

@check-spelling-bot: Could not perform request.

The referenced report comment is hidden (resolved). This probably means the changes have already been applied. Did you mean to apply the most recent report (#660 (comment))?

See log for details.

@gwarf
Copy link
Member Author

gwarf commented Jun 13, 2024

I will just force the merge, not having time to dig further more in this.

@gwarf gwarf merged commit a69c756 into main Jun 13, 2024
@gwarf gwarf deleted the gwarf-patch-tcs branch June 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants