-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve the discovery of projects at sites #278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enolfc
force-pushed
the
improve-auto-config
branch
from
June 14, 2023 09:50
57ff8ec
to
72f66fe
Compare
enolfc
force-pushed
the
improve-auto-config
branch
from
July 6, 2023 12:01
72f66fe
to
d93c48a
Compare
Moved everything into a python module and include testing for it, hopefully will allow us to detect issues before deploymentt
enolfc
force-pushed
the
improve-auto-config
branch
from
July 6, 2023 12:02
d93c48a
to
4aa280d
Compare
gwarf
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (from a quick look... )
You may be able to mark the python code test workflow as required.
Ansible deployment:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not fail if one of the Check-in credentials has no access to the site and still (potentially) produce valid output for other VOs
Want to add tests, so keeping as draft
Related issue :