Remove token from html #8
Conversation
|
I guess I'lI need to pull this branch to the tryggve server to see it action first. And I also realized that it is a highly user-facing feature we may need to inform about when we introduce it in prod :) |
I've already tested it by setting up a mock server and seeing how the website responds to the incoming token. All good here. But yes, users definitely will assume that website broke cause they no longer see the token! Let me know if you'd like some UI updates as well :) |
|
It's now deployed on the https://tryggve.tsd.usit.uio.no server/site. I can login, a few gotchas: The "user-id-string" is not displayed anymore, not sure we want to remove that completely. The copy button does not work for me. I click it, but the content does not seem to reach my clip-board. When I paste in a terminal window, I get the previous content instead. Can you test on the tryggve site? |
|
And we probably want some visual representation of the token on the page. It feels a bit truncated and the previous users will expect "something" to appear. Maybe and icon, with a text "Your token is ready"or similar ? |
Added explicit content-type declaration in the fetch header. Co-authored-by: Yasin <[email protected]>
Specify headers in fetch call.
- Streamline token interface with horizontal layout - Add clear error state when token fetch fails - Update button styling for better visual hierarchy - Improve copy-to-clipboard feedback - Remove redundant UI elements in error state
There was a problem hiding this comment.
We discussed the layout / webpage in the dev meeting last Friday, and we like the improvements, and had few suggestions to make it clearer that
- the username and token are 2 different strings in the web page
- both can and should be possible to copy out by the user
- and that it should be intuitive which is which, and hard to mix up (copying one and thinking it's the other one)
So this may involve an additional button (copy "LS login userid string") in addition to the "LS Login access token", placed in a 2 by 2 layout with the user string and a token representation, making it clear which button copies what element to the clip-board. Happy to explain more if needed :)
Now keeps the token in memory and copies it over directly to the users' clipboard.
Fixes #9