fix(s3): use fs_utils for S3-aware path deletion #49
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace os.path.exists() with fs.exists() for S3 compatibility - Use fs_utils.get_filesystem() for both local and S3 paths - Fixes encoding conflict when retrying failed S3 writes - Aligns with existing fs_utils patterns in codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry logic for failed S3 writes used os.path.exists and shutil.rmtree, causing encoding conflicts with S3 paths.
Replace with fs_utils patterns for S3-aware filesystem access: fs.exists and fs.rm(recursive=True).
Fixes S3 encoding conflicts in Sentinel-1 conversions with retry logic.
identified during data-pipeline iterations https://github.com/EOPF-Explorer/data-pipeline/pulls