Fix incorrect number of blocks in a round #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Producers are actually producing 12 blocks, not 6.
OlegStotsky
changed the title
NiVisser
reviewed
Apr 25, 2019
|
How is this incorrect? You basically wrote the same information that is in my PR. |
|
It's 252 blocks. Not seconds. I have no idea where you got the seconds idea from. You multiply 12 blocks by 21 producers. You get 252. 252 blocks per round. |
|
Sorry, you are right, I did a little brain fart. The seconds part came from the idea that whoever wrote this whitepaper, was refering to the 126 seconds and did actually mean seconds instead of blocks. Anyway, the orginal sentence confused me and that is why I started looking for answers, which you helped clarify. I hope they can commit the changes and get this issue resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Producers are actually producing 12 blocks per turn, not 6.