Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add RECOVER_KEY_SAFE protocol feature #10831

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

conr2d
Copy link
Contributor

@conr2d conr2d commented Oct 24, 2021

Change Description

Implement EEP-9.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@conr2d
Copy link
Contributor Author

conr2d commented Oct 24, 2021

Can you assign anyone who may review this? It would be good if I can get a review before writing test cases.

According to Bitcoin secp256k1 convention, recovery IDs in the range of 27 to 30 are for uncompressed public key, but 31 to 34 for compressed one. For better support for EVM on EOSIO, what about recovering an uncompressed public key (public key point) in case of recover ID 27-30? For this, it needs to merge implementation for missing serialize_ecc_point(). (EOSIO/fc#215)

Copy link
Contributor

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long.

libraries/chain/webassembly/crypto.cpp Outdated Show resolved Hide resolved
libraries/chain/webassembly/crypto.cpp Outdated Show resolved Hide resolved
libraries/chain/webassembly/runtimes/eos-vm.cpp Outdated Show resolved Hide resolved
@conr2d
Copy link
Contributor Author

conr2d commented Nov 10, 2021

@heifner
Thank you for the review. What do you think of recovering uncompressed public key for recovery ID from 27 to 30?

@heifner
Copy link
Contributor

heifner commented Dec 3, 2021

@heifner Thank you for the review. What do you think of recovering uncompressed public key for recovery ID from 27 to 30?

Sorry for the slow response. At this time we would like the uncompressed public key (if added) to come in under a different PR to keep this particular change focused on just having a recover key that does not assert.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants