Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix MacOS 10.15 package installation error #11056

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix MacOS 10.15 package installation error #11056

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a08918d
Try calling brew install eosio twice
nickjjzhao Jan 29, 2022
6ad064a
Disable HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK
nickjjzhao Jan 29, 2022
cd78515
Test if the links are rebuilt before eosio is installed
nickjjzhao Jan 31, 2022
a3ce7d5
Revert "Test if the links are rebuilt before eosio is installed"
nickjjzhao Jan 31, 2022
bafd72d
Add brew upgrade
nickjjzhao Feb 7, 2022
cbb68d2
Add brew doctor
nickjjzhao Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .cicd/test-package.run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ elif [[ $(yum --version 2>/dev/null) ]]; then # RHEL family packaging
perform 'yum install -y /eos/*.rpm'
elif [[ $(brew --version 2>/dev/null) ]]; then # homebrew packaging
perform 'brew update'
perform 'brew --version'
perform 'mkdir homebrew-eosio'
perform 'git init homebrew-eosio'
perform 'cp *.rb homebrew-eosio'
perform "sed -i.bk -e 's/url \".*\"/url \"http:\/\/127.0.0.1:7800\"/' homebrew-eosio/*.rb"
perform "pushd homebrew-eosio && git add *.rb && git commit -m 'test it!' && popd"
perform 'export HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK=false'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explains why installing it twice or running the fix links command works but it's hideous this is the default Homebrew behavior. I don't see a way to force this in the formulae itself.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try (rather than setting this export) brew list --formula | xargs -I % sh -c 'brew unlink %; brew link %' after brew update to see if its a problem with the existing installed formula?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Package failed https://buildkite.com/EOSIO/eosio/builds/32239#3d89b1f3-3a2b-49f6-87f8-f07fc422c033 after trying brew list --formula | xargs -I % sh -c 'brew unlink %; brew link %'. Will keep setting this export as a fix since we can't prove it’s eosio, and the fix suggests its a problem with the existing installed packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix suggests its a problem with the existing installed packages.

I thought the point of this test is that this is a clean image with no existing installed formula. What brew packages are already installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating my comments: the fix suggests some broken linkage of dependents or outdated dependents after installing, upgrading or reinstalling formulae.

perform "brew tap eosio/eosio homebrew-eosio"
perform '{ python3 -m http.server 7800 & } && export HTTP_SERVER_PID=$!'
perform 'sleep 20s'
Expand Down