Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added osmdata rooftop id to Population Estimates fixes #11 #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AmyMikhail
Copy link
Contributor

Per @pbkeating 's issue #11 request and discussion I have added code to the Population estimates case study that uses osmdata to import points for buildings in Kario camp and add them to the map.

@AmyMikhail AmyMikhail added the enhancement New feature or request label Jun 29, 2023
@AmyMikhail AmyMikhail requested a review from aspina7 June 29, 2023 17:15
@aspina7
Copy link
Collaborator

aspina7 commented Jul 13, 2023

Hey @AmyMikhail thanks for doing this. Code osmdata code all looks good, but for the case study I would stick to using the shapefile given, and have the osmdata stuff in an appendix as an optional extra (particularly because if everyone runs this in a class the it'll way overshoot the api limit).
Also as a sidenote, is good practice when working with git to not go over the 80 characters per line (for both code and regular text) - this makes it much easier when reviewing in window. In rstudio you can add a line that shows you where those 80 characters end, to do this go tools > global options > code > display and tick show margin (put 80 in the box). Markdown text with a single return between lines will still show up as a single paragraph, so not an issue there.

Thanks!

@AmyMikhail
Copy link
Contributor Author

Thanks Alex,

I will shift the extra bit to the appendix in that case - hadn't consider the API limit but you are right, if everyone tries to do it at the same time there will likely be issues. So the part I will shift is from line 315 until 427.

Regarding the 80 characters - I do already use that line for code, but had not been using it for markdown text as I thought it would somehow corrupt the automatic wordwrap when the document is rendered - useful to know that it won't. I noticed that if you switch between normal and preview mode, it automatically wraps the markdown text in this way - not sure if/ how this is preserved but if yes, would be a simple thing to do before pushing to git and not have to use manual line breaks for long tracts of text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants