Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #504 Ikea E1743 long press trigger_action #522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

notherealmarco
Copy link

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Breaking change

It's a fix, Should not break anything (READ BELOW).
This fixes issue #504

Proposed change*

As reported in #504, the trigger_action(s) have changed to:

Up hold: move_with_on_off_MoveMode.Up_83
Down hold: move_MoveMode.Down_83_bitmap8.0_bitmap8.0
Release: stop_with_on_off

I don't actually know if this is related to a ZHA update or Ikea did change something in the latest firnware.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

@github-actions
Copy link
Contributor

Hey @notherealmarco, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Copy link

@GuiGeeK69 GuiGeeK69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Line 204 - E07 : (works locally for Long press (Dimming) Up and Down)

 button_up_short: ['on']
  button_up_long: [move_with_on_off_MoveMode.Up_83]
  button_up_release: [stop_with_on_off]
  button_down_short: ['off']
  button_down_long: [move_MoveMode.Down_83_0_0]
  button_down_release: [stop_with_on_off]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants