(Z2M) OSRAM AC025XX00NJ / Philips 8718699693985: fix and update #615
Conversation
|
Hey @alexdelprete, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
There was a problem hiding this comment.
LGTM. Thanks for your contribution @alexdelprete! 🚀 I will make sure to update the blueprint with changes introduced by previous PRs on the IKEA controllers, update docs and changelog before merging.
| button_down_short: [down] | ||
| button_down_long: [down_hold] | ||
| button_down_release: [down_release] | ||
| # source: https://www.zigbee2mqtt.io/devices/AC0251100NJ_AC0251600NJ_AC0251700NJ.html#actions |
There was a problem hiding this comment.
Nice idea to add a comment with the source! We should keep it in mind for the other controllers as well.
There was a problem hiding this comment.
I learned this the hard way: when I find useful info for an integration, and I don't write it in the code, I have a hard time finding it again. A best practice I learned studying code of expert devs. I'm just an old tinkerer. :)
| @@ -141,17 +149,28 @@ variables: | |||
| button_short: [on_short_release] | |||
| button_long: [on_hold] | |||
| button_release: [on_long_release] | |||
| zigbee2mqtt: | |||
| # source: https://www.zigbee2mqtt.io/devices/8718699693985.html#action-enum | |||
There was a problem hiding this comment.
So much time has passed that I even forgot I made this PR. Thanks for merging it.
Updated Actions Mapping as per Z2M docs: https://www.zigbee2mqtt.io/devices/AC0251100NJ_AC0251600NJ_AC0251700NJ.html#actions
|
Hey @EPMatt, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
|
Hey @EPMatt, ✅ Your contribution passed all the checks, awesome! Thanks again for dedicating your precious time to this project. 🔥 📝 Updated blueprints included in this PR can be tested by importing them in Home Assistant via the following links. https://github.com/alexdelprete/awesome-ha-blueprints/blob/main/blueprints/controllers/osram_ac025xx00nj/osram_ac025xx00nj.yaml |
EPMatt
changed the title
…18699693985: fix and update (#615) * Updated actions_mapping for Zigbee2MQTT Updated Actions Mapping as per Z2M docs: https://www.zigbee2mqtt.io/devices/AC0251100NJ_AC0251600NJ_AC0251700NJ.html#actions * Added Zigbee2MQTT support for Philips 8718699693985 Hue Smart Button * copy new helper json marshaling from ikea controllers, bump version to 2025.01.05 * docs: add z2m support, update changelog --------- Co-authored-by: EPMatt <[email protected]>
(Z2M) OSRAM AC025XX00NJ / Philips 8718699693985: fix and update (EPMatt#615)
|
Hi there, 🔒 This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you want to submit a contribution to the project, you can open a new PR. Thanks! |
Proposed change*
Fix for OSRAM AC025XX00NJ SMART+ Switch Mini:
Update for Philips 8718699693985 Hue Smart Button:
Checklist*
npm run formatbefore submitting my Pull Request.