Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1828 - fixed an issue with shifting formula addresses on sorting a range #1830

Merged
merged 9 commits into from
Feb 6, 2025

Conversation

swmal
Copy link
Contributor

@swmal swmal commented Jan 29, 2025

See #1828

@swmal swmal added the bug Something isn't working label Jan 29, 2025
@swmal swmal requested a review from JanKallman January 29, 2025 12:11
@swmal swmal self-assigned this Jan 29, 2025
@swmal swmal requested a review from OssianEPPlus January 31, 2025 16:32
@swmal
Copy link
Contributor Author

swmal commented Jan 31, 2025

@JanKallman and @OssianEPPlus - you can both have a look at this. Ossians RedYellowGreen test passes now and I also added another test where the worksheet dimension stars above the sorted range, which triggers a different behaviour in Excel...

Copy link
Contributor

@OssianEPPlus OssianEPPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me now!

@JanKallman JanKallman merged commit e831d60 into develop7 Feb 6, 2025
1 check passed
@JanKallman JanKallman deleted the bug/i1828 branch February 6, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants