[Fix] Update trader add/remove packets to limits for RoF2 #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update trader add/remove to limit for RoF2
|
Looks great, appreciate the contribution. Minor nitpick, could we change the names? Like |
|
Thanks Kingly. Updated accordingly. |
Akkadius
approved these changes
Jan 19, 2025
Merged
MortimerGreenwald
pushed a commit
to MortimerGreenwald/Server
that referenced
this pull request
Jan 27, 2025
* Update trader add/remove to limit for RoF2 Update trader add/remove to limit for RoF2 * Update for feedback --------- Co-authored-by: Mitch Freeman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As previously noted, the RoF2 limit for the number of traders is 600. If there are already 600 traders within the client and a new trader is enabled, the 601st would crash the client.
This fix tracks that condition and does not send the packet.
Type of change
Please delete options that are not relevant.
Testing
Tested with a client that had 600 traders, and then enabled a new trader. Prior the client would crash. Post, the client would not crash.
Clients tested:
RoF2 against linux and windows builds
Checklist