Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Support for Item Previews #4599

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kinglykrab
Copy link
Contributor

Description

  • Adds support for the Item Preview window in merchants.
  • Credit to @dannuic.

Type of change

  • New feature

Testing

image
image
image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@neckkola
Copy link
Contributor

Good morning. Kingly, I wonder if we should move the struct verification into the decode/encoders so that when we ever get the other clients online, we can have source be generic, and do the packet differences there? It looks like we are doing most of that, at least on the decode side within client_packet. I also see RoF changes though no RoF opcode. Do we need to add to patch_rof?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants