Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Alternate Bazaar Search Approach #4600

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neckkola
Copy link
Contributor

Description

For Server Operators who would like to have multi-instanced bazaars with traders over the 600 RoF2 Client limitation, this feature upgrade allows for an alternate approach to the bazaar.

This is behind a rule, and is disabled by default. When enabled, it changes the bazaar experience as follows:

  • When a player is not within a Bazaar instance, they will be sent one trader (for display in the Bazaar Window trader dropdown) for each Bazaar Shard. These are labelled Bazaar Shard 1, 2, 3, etc. This will allow the player to search all Bazaar Shards (using All Traders) or a single Bazaar Shard. Results are assigned to the Bazaar Shard # instead of the trader name.
  • The player can continue to use parcel delivery from a Bazaar Shard # trader. This works as normal.
  • When the player is within a Bazaar instance, they will be sent the actual trader name for their instance and Bazaar Shard # for all other instances.

In essence, with this rule enabled, you can have hundreds/thousands of traders and search across all of them.

A version of this has been running in THJ for a few days, though this version is ruled allowing Server Operators to decide. Would appreciate any testing that folks may want to do.

Note: This is built on top of the Fix_TraderAddRemoveLimitForRoF2, so includes that PR.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing

https://www.youtube.com/watch?v=LEYzIegRYbs

Clients tested:
RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I have made corresponding changes to the documentation (if applicable, if not delete this line)
  • I own the changes of my code and take responsibility for the potential issues that occur

This adds an alternate bazaar search allowing multinstance bazaar searching and traders above 600.  Allows searches based on Bazaar Shard
@Akkadius Akkadius changed the title [Feature[ Add Alternate Bazaar Search Approach [Feature] Add Alternate Bazaar Search Approach Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant