-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mMarFoi2 EAR #108
mMarFoi2 EAR #108
Conversation
Attention @gitcruz, you have changed more than one file! |
Hi @diegomics, I don't understand the automatic bot error. This time I am pretty sure I uploaded just one EAR. Of course, this is inside two folders called Martes_foina/mMarFoi2/ Please let me know if the PR is good and we can assign a reviewer. Thanks |
Hi @gitcruz Please remove Coenonympha oedippus from this PR :) |
Hi @gitcruz, thanks for sending the EAR of Martes foina. |
Hi @diegomics, do you agree to supervise this assembly? |
Ok |
|
Hi @bistace, do you agree to review this assembly? |
Yes |
Thanks for agreeing! |
Hello @gitcruz, very nice assembly! The HiC map is hard to review because there are a lot of intra-chromosomal contacts. However I don't see anything out of place, the telomeres are present at the extremities and coverage also looks normal across the entire chromosomes. To me this looks good to go! |
Thanks @bistace, yes the assembly looks good. |
Dear all, Thanks @bistace for the review! @diegomics I agree on your comment about SUPER_4 @ 46 Kbp. Despite of being already contigged is likely repetitive sequence (based on ONT coverage) that better fits into the gap at 127,3 Kb. We will produce a final savestate and place it inside the same folder. Do you think is necessary to produce a new EAR? Please please accept the PR and merge it when you can. I think we have this genome and its complete mitochondrion ready to submit. Thanks! |
It's a tricky region. There are reads spanning from the left side of the gap at 46 to the right side of the gap at 127. I will browse the alignments some more to see where to make the break and join. But after the BG24 sessions today. |
@gitcruz please share the savestate, so we can move forward and approve it to save time ;) |
I took care of it. Here is the savestate. After examining BAM with IGV, I will make precise edit in tpf after pretext-to-tpf, before rapid_join.pl |
Oh and I localized the unloc on SUPER_8 and the unloc on SUPER_Y. No more unlocs or unplaced! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, seems good to me!
Thanks @bistace for the review. Congrats on the assembly @gitcruz! After @diegomics confirmation, you can start with the assembly submission to save time. |
Dear @diegomics,
In this case is it strictly necessary to generate a new EAR recomputing all
stats?
Thanks.
Fernando
…On Tue, 29 Oct 2024 at 08:41, Diego De Panis ***@***.***> wrote:
Nice! Thanks @bistace <https://github.com/bistace>. @gitcruz
<https://github.com/gitcruz> please go ahead and start uploading the
fasta of the last version to ENA. Don't forget to regenerate the PDF in the
meantime so we can merge this PR and release the reviewer ;)
—
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB34KVMJV5TI7HOBNIBM6ZLZ5433DAVCNFSM6AAAAABQTNDLFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTGQ3DSNBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
You don't need to regenerate the pretext map and the blobplot, only update gfastats (result should be different) and merqury and busco (not sure it will be different but maybe). And only on the curated assembly! |
makes sense, Thanks!
…On Tue, 29 Oct 2024 at 10:02, Diego De Panis ***@***.***> wrote:
You don't need to regenerate the pretext map and the blobplot, only update
gfastats (result should be different) and merqury and busco (not sure it
will be different but maybe). And only on the curated assembly!
—
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB34KVI7VR5L3AHPJ5IROSDZ55FL5AVCNFSM6AAAAABQTNDLFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTGYZDQMZYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The researcher has updated the EAR PDF. Please review the assembly @bistace. |
Hi @diegomics, I just uploaded the updated EAR. Could you merge the PR with the main branch? Thanks, |
Assembly review request