Initial attempt of setting default constituent value. #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boulderdaze
approved these changes
Jul 14, 2023
nusbaume
requested changes
Jul 19, 2023
Updating debug message from PR. Co-authored-by: Jesse Nusbaumer <[email protected]>
…nge to correctly handle ine length.
nusbaume
requested changes
Aug 1, 2023
Updating not equal comparison to match current code style. Adding line number and file name to error message. Co-authored-by: Jesse Nusbaumer <[email protected]>
Updating not equal comparison to match current code style. Adding line number and file name to error message. Co-authored-by: Jesse Nusbaumer <[email protected]>
|
Good call on both changes! Updated. |
nusbaume
approved these changes
Aug 1, 2023
|
@peverwhee @cacraigucar It looks like I'll need these changes as well in order to properly validate the physics schemes in |
cacraigucar
requested changes
Aug 10, 2023
peverwhee
approved these changes
Aug 11, 2023
cacraigucar
approved these changes
Aug 21, 2023
|
@cacraigucar I updated the error message formatting on this last commit, could you take a look at the implementation and just let me know if it seems reasonable? Just want to make sure the way I'm using the string concatenation is consistent. |
cacraigucar
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementation will attept to find constituent value from file, otherwise will default to value declared in meta files, otherwise 0.