Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest framework tag #247

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Update to latest framework tag #247

merged 5 commits into from
Mar 13, 2024

Conversation

peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Feb 14, 2024 •
edited
Loading

  • Update some mismatched units
  • Fix constituent call
  • Add dynamic_constituents variable to be passed to register_constituents

Tests run:

  • Ran test case for held-suarez and kessler with ncdata_check - no answer changes.

@peverwhee peverwhee marked this pull request as ready for review March 11, 2024 19:35
nusbaume
nusbaume reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I did have one question that might be good to figure out first.

Externals_CAM.cfg Outdated Show resolved Hide resolved
@peverwhee peverwhee merged commit d809cf1 into ESCOMP:development Mar 13, 2024
6 checks passed
@nusbaume nusbaume mentioned this pull request May 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cacraigucar cacraigucar cacraigucar approved these changes

@nusbaume nusbaume nusbaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CAM Development
Status: Tag
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peverwhee @cacraigucar @nusbaume