-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement and finish MPAS dynamical core initialization #267
Implement and finish MPAS dynamical core initialization #267
Commits on Jun 6, 2024
-
Remove relative humidity from MPAS input stream
Relative humidity (`relhum`) is a diagnostic variable. It should not be included in MPAS input stream.
Configuration menu - View commit details
-
Copy full SHA for 01af7c7 - Browse repository at this point
Copy the full SHA 01af7c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b69ea9 - Browse repository at this point
Copy the full SHA 6b69ea9View commit details -
Handle the allocation of constituents more carefully
More elaborate error checking. Also use a more descriptive name for number of constituents.
Configuration menu - View commit details
-
Copy full SHA for 61ccb16 - Browse repository at this point
Copy the full SHA 61ccb16View commit details -
* Finish MPAS dynamical core initialization. * Support for deferring the definition of constituents until run-time. * Accessor functions/subroutines for querying: * Local mesh dimensions. * Constituent names and indexes. * Mapping between constituent indexes and MPAS scalar indexes.
Configuration menu - View commit details
-
Copy full SHA for bf2a21d - Browse repository at this point
Copy the full SHA bf2a21dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9435535 - Browse repository at this point
Copy the full SHA 9435535View commit details -
Reimplement
parse_stream_name
for greater flexibilityIt is now possible to construct an arbitrary list of variables to input/output data to/from MPAS dynamical core. This functionality may be overengineered, but it supports what CAM-SIMA needs.
Configuration menu - View commit details
-
Copy full SHA for be95a75 - Browse repository at this point
Copy the full SHA be95a75View commit details
Commits on Jun 12, 2024
-
Fix and enhance handling of variables during input
There are two kinds of variables in MPAS: ordinary variables and variable arrays. The old implementation would always skip the latter entirely when encountering them during input. The new implementation correctly distinguishes between the two, and checks whether each variable is eligible to be input.
Configuration menu - View commit details
-
Copy full SHA for 6c848ce - Browse repository at this point
Copy the full SHA 6c848ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for c38a9b3 - Browse repository at this point
Copy the full SHA c38a9b3View commit details -
Move all shared variables to
dyn_comp
due to circular dependency issueThe instance of MPAS dynamical core resides in `dyn_comp`. `dyn_grid` depends on `dyn_comp`, but not vice versa.
Configuration menu - View commit details
-
Copy full SHA for 932ef82 - Browse repository at this point
Copy the full SHA 932ef82View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0ac03b - Browse repository at this point
Copy the full SHA a0ac03bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c564c0 - Browse repository at this point
Copy the full SHA 0c564c0View commit details
Commits on Jun 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a87368a - Browse repository at this point
Copy the full SHA a87368aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7dccf3 - Browse repository at this point
Copy the full SHA b7dccf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03cf4e0 - Browse repository at this point
Copy the full SHA 03cf4e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef3f076 - Browse repository at this point
Copy the full SHA ef3f076View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a6451c - Browse repository at this point
Copy the full SHA 7a6451cView commit details
Commits on Jun 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b3f1937 - Browse repository at this point
Copy the full SHA b3f1937View commit details
Commits on Jul 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 77cf091 - Browse repository at this point
Copy the full SHA 77cf091View commit details
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d3567bf - Browse repository at this point
Copy the full SHA d3567bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 724d5c8 - Browse repository at this point
Copy the full SHA 724d5c8View commit details
Commits on Jul 11, 2024
-
Maintain consistent style with others.
Configuration menu - View commit details
-
Copy full SHA for d57d286 - Browse repository at this point
Copy the full SHA d57d286View commit details
Commits on Jul 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3ca360b - Browse repository at this point
Copy the full SHA 3ca360bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cc38a4 - Browse repository at this point
Copy the full SHA 9cc38a4View commit details
Commits on Jul 24, 2024
-
Use
max
intrinsic when determining the number of constituentsSame logic, but the statement is now more compact.
Configuration menu - View commit details
-
Copy full SHA for 155b51c - Browse repository at this point
Copy the full SHA 155b51cView commit details -
Use whole array section when assigning arrays
The statement is now clearer on its intent. Other similar instances in the code already follow this style.
Configuration menu - View commit details
-
Copy full SHA for b2ef93e - Browse repository at this point
Copy the full SHA b2ef93eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0376873 - Browse repository at this point
Copy the full SHA 0376873View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3308a26 - Browse repository at this point
Copy the full SHA 3308a26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 149cbca - Browse repository at this point
Copy the full SHA 149cbcaView commit details
Commits on Jul 26, 2024
-
Avoid explicit initialization of pointers
According to "8.4 Initialization", it states "Explicit initialization of a variable that is not in a common block implies the SAVE attribute". This also applies to pointer variables like here. Avoid the implied SAVE attribute by removing explicit initialization. Uphold the principle of least astonishment.
Configuration menu - View commit details
-
Copy full SHA for a731e97 - Browse repository at this point
Copy the full SHA a731e97View commit details -
Also add
subname
to internal subroutinesEasier to pinpoint where error occurs.
Configuration menu - View commit details
-
Copy full SHA for d18264b - Browse repository at this point
Copy the full SHA d18264bView commit details -
Adjust validity check for coupling time interval and time step
Zero or negative values are not allowed. Others are just fine.
Configuration menu - View commit details
-
Copy full SHA for 6428560 - Browse repository at this point
Copy the full SHA 6428560View commit details