Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes CCPP scheme dependencies in the build #282

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

mattldawson
Copy link
Collaborator

Uses updated CCPP-generated data to include scheme dependencies in the CAM-SIMA build.

In draft until ESCOMP/atmospheric_physics#102 is merged.

@mattldawson mattldawson marked this pull request as ready for review August 8, 2024 19:38
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but did have one change request, which I am happy to discuss if need be. Thanks!

cime_config/config_component.xml Outdated Show resolved Hide resolved
@nusbaume
Copy link
Collaborator

@mattldawson Are you ok with me pushing to this PR? I found one small issue when running our regression tests.

Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattldawson !

small change and submodule question

ccpp_framework Outdated Show resolved Hide resolved
cime_config/config_component.xml Outdated Show resolved Hide resolved
@mattldawson mattldawson merged commit 822321b into ESCOMP:development Aug 20, 2024
8 checks passed
@mattldawson mattldawson deleted the develop-277-dependencies branch August 20, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants