Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_066: Negative wet dep messages #1228

Merged
merged 6 commits into from
Feb 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions doc/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,4 +1,61 @@
===============================================================

Tag name: cam6_4_066
Originator(s): fvitt
Date: 14 Feb 2025
One-line Summary: Limit extraneous log file messages from aerosol wet deposition
Github PR URL: https://github.com/ESCOMP/CAM/pull/1228

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

Ignore the insignificant negative values produced by aerosol wet deposition module.
Report the larger (possibly significant) negative values in the log file and abort
when DEBUG is TRUE.
Issue #1132 -- Extraneous output to cesm.log

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the boundary datasets: N/A

Describe any substantial timing or memory changes: N/A

Code reviewed by: cacraigucar

List all files eliminated: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
M src/chemistry/aerosol/wetdep.F90
- limit log messages as described above

If there were any failures reported from running test_driver.sh on any test
platform, and checkin with these failures has been OK'd by the gatekeeper,
then copy the lines from the td.*.status files for the failed tests to the
appropriate machine below. All failed tests must be justified.

derecho/intel/aux_cam:
FAIL ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s COMPARE_base_rest
FAIL SMS_Ld1.f09_f09_mg17.FCHIST_GC.derecho_intel.cam-outfrq1d BASELINE /glade/campaign/cesm/community/amwg/cam_baselines/cam6_4_065_intel: DIFF
- pre-existing failures due to HEMCO not having reproducible results (issues #1018 and #856)

FAIL SMS_D_Ln9.f19_f19_mg17.FXHIST.derecho_intel.cam-outfrq9s_amie SETUP
FAIL SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s SETUP
- pre-existing failures due to build-namelist error requiring CLM/CTSM external update

derecho/nvhpc/aux_cam: All PASS

izumi/nag/aux_cam: All PASS

izumi/gnu/aux_cam:
FAIL ERC_D_Ln9.f10_f10_mg37.QPSPCAMM.izumi_gnu.cam-outfrq3s
- pre-existing failure introduced in cam6_4_065

Summarize any changes to answers: Bit-for-bit unchanged

===============================================================
===============================================================

Tag name: cam6_4_065
Expand Down
2 changes: 1 addition & 1 deletion src/atmos_phys
Submodule atmos_phys updated 56 files
+56 −0 doc/ChangeLog
+255 −174 doc/NamesNotInDictionary.txt
+89 −0 schemes/cloud_fraction/cloud_fraction_fice.F90
+49 −0 schemes/cloud_fraction/cloud_fraction_fice.meta
+20 −4 schemes/musica/micm/musica_ccpp_micm.F90
+84 −58 schemes/musica/musica_ccpp.F90
+1 −1 schemes/musica/musica_ccpp.meta
+323 −0 schemes/musica/musica_ccpp_species.F90
+201 −88 schemes/musica/tuvx/musica_ccpp_tuvx.F90
+103 −0 schemes/musica/tuvx/musica_ccpp_tuvx_aerosol_optics.F90
+145 −0 schemes/musica/tuvx/musica_ccpp_tuvx_gas_species.F90
+11 −1 schemes/musica/tuvx/musica_ccpp_tuvx_height_grid.F90
+219 −0 schemes/musica/tuvx/musica_ccpp_tuvx_load_species.F90
+1 −1 schemes/musica/tuvx/musica_ccpp_tuvx_surface_albedo.F90
+68 −0 schemes/sima_diagnostics/zm_convr_tendency_diagnostics.F90
+70 −0 schemes/sima_diagnostics/zm_convr_tendency_diagnostics.meta
+205 −0 schemes/sima_diagnostics/zm_diagnostics.F90
+207 −0 schemes/sima_diagnostics/zm_diagnostics.meta
+81 −0 schemes/sima_diagnostics/zm_evap_tendency_diagnostics.F90
+81 −0 schemes/sima_diagnostics/zm_evap_tendency_diagnostics.meta
+67 −0 schemes/sima_diagnostics/zm_momtran_tendency_diagnostics.F90
+75 −0 schemes/sima_diagnostics/zm_momtran_tendency_diagnostics.meta
+79 −0 schemes/sima_diagnostics/zm_tendency_diagnostics.F90
+69 −0 schemes/sima_diagnostics/zm_tendency_diagnostics.meta
+29 −0 schemes/utilities/to_be_ccppized_temporary.F90
+22 −0 schemes/utilities/to_be_ccppized_temporary.meta
+26 −0 schemes/zhang_mcfarlane/set_deep_conv_fluxes_to_general.F90
+31 −0 schemes/zhang_mcfarlane/set_deep_conv_fluxes_to_general.meta
+46 −0 schemes/zhang_mcfarlane/set_general_conv_fluxes_to_deep.F90
+103 −0 schemes/zhang_mcfarlane/set_general_conv_fluxes_to_deep.meta
+61 −8 schemes/zhang_mcfarlane/zm_conv_convtran.F90
+91 −29 schemes/zhang_mcfarlane/zm_conv_convtran.meta
+29 −50 schemes/zhang_mcfarlane/zm_conv_evap.F90
+84 −68 schemes/zhang_mcfarlane/zm_conv_evap.meta
+14 −9 schemes/zhang_mcfarlane/zm_conv_momtran.F90
+81 −66 schemes/zhang_mcfarlane/zm_conv_momtran.meta
+83 −163 schemes/zhang_mcfarlane/zm_convr.F90
+148 −144 schemes/zhang_mcfarlane/zm_convr.meta
+195 −0 schemes/zhang_mcfarlane/zm_convr_namelist.xml
+47 −1 suites/suite_cam7.xml
+2 −2 test/docker/Dockerfile.musica
+2 −2 test/docker/Dockerfile.musica.no_install
+34 −5 test/musica/CMakeLists.txt
+51 −26 test/musica/test_musica_api.F90
+217 −0 test/musica/test_musica_species.F90
+97 −0 test/musica/tuvx/CMakeLists.txt
+85 −0 test/musica/tuvx/test_tuvx_aerosol_optics.F90
+476 −0 test/musica/tuvx/test_tuvx_gas_species.F90
+10 −1 test/musica/tuvx/test_tuvx_height_grid.F90
+362 −0 test/musica/tuvx/test_tuvx_load_species.F90
+38 −0 test/test_suites/suite_zhang_mcfarlane.xml
+1 −1 to_be_ccppized/ccpp_tuvx_utils.F90
+151 −0 to_be_ccppized/error_messages.F90
+6 −0 to_be_ccppized/namelist_utils.F90
+759 −0 to_be_ccppized/wv_sat_methods.F90
+1,483 −0 to_be_ccppized/wv_saturation.F90
Loading