Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choice of pressure in the CLMU building energy model #2755

Open
cathyxinchangli opened this issue Sep 12, 2024 · 6 comments
Open

Choice of pressure in the CLMU building energy model #2755

cathyxinchangli opened this issue Sep 12, 2024 · 6 comments
Assignees
Labels
science Enhancement to or bug impacting science

Comments

@cathyxinchangli
Copy link
Contributor

Brief summary of bug

In the CLMU building energy model (BEM), standard pressure is assumed when calculating indoor air density. It may be more realistic and accurate to assume bottom layer of atmosphere pressure, which is used by CLMU to calculate canyon air properties, since indoor and outdoor pressure differences are usually small.

General bug information

CTSM version you are using: ctsm5.2.001

Does this bug cause significantly incorrect results in the model's science? Not much (see below for details)

Details of bug

I changed the pressure used in the air density calculation in BEM from standard pressure to bottom layer of atmosphere pressure of the corresponding grid cell, and compared results from land-only simulations of the year 2000 before and after the change. The change leads to a small reduction in urban 2m air temperature (up to -0.08 K) and a small increase in urban 2m relative humidity (up to 0.25%) in places of higher altitude. This is likely due to a reduction in urban air-conditioning energy flux (up to -0.9 W/m^2 of urban area) and urban heating energy flux (up to -3 W/m^2 of urban area) caused by reduced indoor air density in those areas. Plots are available here:
bugfix_pressure_4vars_diff_global_2000mean_urbanarea.pdf

Important details of your setup / configuration so we can reproduce the bug

The code change was done in this commit on my CTSM fork.

Below are details of the simulations I ran to produce the results above:

  • compset: 2000_DATM%GSWP3v1_CLM51%SP_SICE_SOCN_MOSART_CISM2%NOEVOLVE_SWAV
  • resolution: f09_g17
  • machine: Derecho
@ekluzek ekluzek added next this should get some attention in the next week or two. Normally each Thursday SE meeting. science Enhancement to or bug impacting science labels Sep 12, 2024
@samsrabin
Copy link
Collaborator

Bugfix and urban, so should be allowed now that we're in the chill.

@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 12, 2024
@olyson
Copy link
Contributor

olyson commented Sep 12, 2024

Thanks for this @cathyxinchangli . Do you have time to create a branch off of CTSM main and issue a PR? If not, I'm happy to do it.

@cathyxinchangli
Copy link
Contributor Author

Hi @olyson! I'd be happy to, but it seems my account doesn't have the authorization to do that. However, I can create a PR from the branch on my forked repository. Would that be okay? Or if I am allowed to be given the authorization then I can create a branch then!

@olyson
Copy link
Contributor

olyson commented Sep 12, 2024

Yes, sorry for the confusion, I just meant that your CTSM fork should be updated to the latest, you have ctsm5.2.001, and the latest tag is ctsm5.2.028.

@cathyxinchangli
Copy link
Contributor Author

I see! Sure, I just synced the branch to the CTSM main. I will create a pull request now!

@cathyxinchangli
Copy link
Contributor Author

PR #2758 is up now! @olyson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
science Enhancement to or bug impacting science
Projects
None yet
Development

No branches or pull requests

4 participants