Change the choice of pressure in CLMU building energy model (BEM) #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change pressure used in air density calculation in the BEM from standard pressure to bottom layer of atmosphere pressure
olyson
requested changes
Sep 17, 2024
Changes made for PR ESCOMP#2758.
|
Thank you for the suggestions, @olyson! I have updated the code. Please let me know if you would like me to run additional tests or help with anything else! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In the CLMU BEM, the choice of pressure for calculating indoor air density is changed from standard pressure to bottom layer of atmosphere pressure of the corresponding grid cell.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #): #2755
Are answers expected to change (and if so in what way)?
Yes, some urban variables such as urban 2m air temperature, 2m relative humidity, urban air-conditioning and heating energy fluxes will change slightly. See #2755 for details.
Any User Interface Changes (namelist or namelist defaults changes)? No.
Does this create a need to change or add documentation? Did you do so?
I have updated the inline documentation in the code where it's needed. I personally don't think it requires changing or adding documentation elsewhere, but if so, I would be happy to help.
Testing performed, if any:
The original code change was done based on ctsm5.2.001, with which I performed one land-only simulation for the year 2000 under DEBUG mode, and the simulation ran as expected. Details are available in #2755. I did not run additional tests after syncing the branch to the latest CTSM main.