-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check in build-namelist_test.pl #2678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdebolskiy
added
support
user or developer needs help
tag: simple bfb
testing
additions or changes to tests
labels
Aug 8, 2024
You can test this by misspelling a subkey for one of the existing ones. |
Fixes #2673 |
mvdebolskiy
force-pushed
the
fix-namelist-tester
branch
from
August 22, 2024 15:56
915af95
to
e271432
Compare
ekluzek
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. I'm going to bring this in as it will help with other namelist work we will be working on.
…o fix-namelist-tester
…e all set in fail, warn, and finidat tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added a check in
failtest
,warntest
,finidat_files
, so when a new test or finidat file are added and one of the subkeys is misspelled you will get an error and tester will die.Specific notes
Contributors other than yourself, if any:
@ekluzek
Resolves #2673