DOM flow in Mosart #64
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmizukami
reviewed
Apr 20, 2023
src/riverroute/DommasbMod.F90
Outdated
| !domsur (kg/m2*s) ,domH (kg/m2), ehout (m/s), domHout (kg/m2*s), qsur (m/s), wh (m) | ||
| Tdom%domHout(iunit,ntdom) = -TRunoff%ehout(iunit,nt) * (Tdom%domH(iunit,ntdom) + Tdom%domsur(iunit,ntdom) * theDeltaT)/(TRunoff%wh(iunit,nt)-TRunoff%dwh(iunit,nt)*theDeltaT+TRunoff%qsur(iunit,nt)*theDeltaT) | ||
| !we dont want a too high out | ||
| Tdom%domHout(iunit,ntdom) = min(-TRunoff%ehout(iunit,nt) * 0.3_r8, Tdom%domHout(iunit,ntdom)) |
There was a problem hiding this comment.
ehout is overland flow [m/s] into tributaries. and domHout is concentration [kg/m2/s] going to trigutary. how does different units work out for this comparison?
src/riverroute/DommasbMod.F90
Outdated
| !we dont want a too high out | ||
| Tdom%domHout(iunit,ntdom) = min(-TRunoff%ehout(iunit,nt) * 0.3_r8, Tdom%domHout(iunit,ntdom)) | ||
| !cannot be more be less than 0, lower boundary | ||
| Tdom%domHout(iunit,ntdom) = max(0._r8,Tdom%domHout(iunit,ntdom)) |
There was a problem hiding this comment.
does this happen (negative domHout) because of negative flow?
src/riverroute/DommasbMod.F90
Outdated
Comment on lines
35
to
37
| Tdom%domHout(iunit,ntdom) = min((Tdom%domH(iunit,ntdom)+Tdom%domsur(iunit,ntdom)*theDeltaT)/theDeltaT,Tdom%domHout(iunit,ntdom)) | ||
|
|
||
| Tdom%domH(iunit,ntdom) = max(0._r8,Tdom%domH(iunit,ntdom) + (Tdom%domsur(iunit,ntdom) - Tdom%domHout(iunit,ntdom))* theDeltaT) |
There was a problem hiding this comment.
I know why you did this (you cannot output more that you get from surface flow and storage), but this also causes balance off (but maybe ok?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.