Add TUV-x height grid updates #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d' into 95-update-tuvx-temp
mattldawson
changed the title
boulderdaze
changed the title
boulderdaze
requested changes
Oct 15, 2024
Comment on lines
+46
to
+50
| height_grid => create_height_grid( vertical_layer_dimension, & | ||
| vertical_interface_dimension, errmsg, errcode ) | ||
| if (errcode /= 0) return | ||
| call grids%add( height_grid, error ) | ||
| if (has_error_occurred( error, errmsg, errcode )) return |
There was a problem hiding this comment.
I think the error checking function call can be consistent unless there is reason to not to?
Suggested change
| height_grid => create_height_grid( vertical_layer_dimension, & | |
| vertical_interface_dimension, errmsg, errcode ) | |
| if (errcode /= 0) return | |
| call grids%add( height_grid, error ) | |
| if (has_error_occurred( error, errmsg, errcode )) return | |
| height_grid => create_height_grid( vertical_layer_dimension, & | |
| vertical_interface_dimension, errmsg, errcode ) | |
| if (has_error_occurred( error, errmsg, errcode )) return | |
| call grids%add( height_grid, error ) | |
| if (has_error_occurred( error, errmsg, errcode )) return |
|
|
||
| type(grid_t), intent(inout) :: height_grid | ||
| real(kind_phys), intent(in) :: host_midpoints(:) ! km | ||
| real(kind_phys), intent(in) :: host_edges(:) ! km |
There was a problem hiding this comment.
Is the term edge equivalent to interface? If so, can we use interface across the code base to enhance the consistency?
Suggested change
| real(kind_phys), intent(in) :: host_edges(:) ! km | |
| real(kind_phys), intent(in) :: host_interface(:) ! km |
|
Looks like I can't commit the code to Matt's fork, which is expected. I am going to create a new branch in this repository for this PR so we can push the commits |
|
Opened the same PR. Closes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates TUV-x height grid with CAM-SIMA state data before calculating rate constants.
Uses geopontential height values to calculate actual heights above sea level, as currently done in the CAMChem gas-phase chemistry module. If there is a better way to get these height values, we can update this PR.
closes #94