Implement ccpp_const_get_index in to_be_ccppized to avoid circular dependencies #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar dependencies.
nusbaume
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Thanks @jimmielin! This looks good to me (I just have one minor comment suggestion).
Co-authored-by: Jesse Nusbaumer <[email protected]>
cacraigucar
approved these changes
Oct 17, 2024
jimmielin
added a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Oct 18, 2024
…hys) (#314) Companion atmospheric_physics PR: ESCOMP/atmospheric_physics#135 This avoids a circular dependency if schemes require const_get_index, which presently depends on cam_ccpp_cap, which depends on individual schemes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This routine can be shared by CAM-SIMA code (companion PR to be filled) and
atmospheric_physicsschemes by passing in the CCPP constituents pointer object.This loop-based workaround is to avoid a dependency on
cam_ccpp_capwhich would in turn depend on all schemes creating a circular dependency.