use mid-point of time step for time stamp of history file for cesm-coupling run #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g with cesm-coupling mode
ekluzek
approved these changes
Dec 18, 2024
| @@ -203,6 +203,10 @@ SUBROUTINE output(ierr, message) | |||
| index_write_all = arth(1,1,nRch_local) | |||
| end if | |||
|
|
|||
| if (trim(runMode)=='cesm-coupling') then | |||
There was a problem hiding this comment.
Add a comment to just say that we are setting the timestamp of the average history output as the midpoint of the average.
There was a problem hiding this comment.
added comment: "For cesm coupling mode, the timestamp of the average history output is the midpoint of time bounds"
| @@ -14,6 +14,8 @@ MODULE public_var | |||
|
|
|||
| ! physical constants | |||
| real(dp), parameter,public :: pi=3.14159265359_dp ! pi | |||
| real(dp), parameter,public :: Cw=4190.0_dp ! heat capacity of water [J/kg/K] | |||
There was a problem hiding this comment.
Check that these agree with the current values set in the shr_const_mod.F90 code under the share directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CESM will require the component uses the mid-point of the output time step if average is used for aggregation.
For now, all the history file uses average for output variable aggregation in the history file.
This PR enforces time stamp in the history file is the mid-point of the time stamp if
cesm-couplingis onresolve #413