Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes DAE.ww3a.ADWAV from cime_developers #4474

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented Aug 15, 2023

Remove DAE.ww3a.ADWAV from cime_developers. E3SM has removed
the ww3a grids, which caused this to fail.

Test suite: ./scripts/create_test cime_developer
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a

Fixes n/a
User interface changes?: N
Update gh-pages html (Y/N)?: N

@jasonb5
Copy link
Collaborator Author

jasonb5 commented Aug 15, 2023

Removed from E3SM with E3SM-Project/E3SM@352f737.

@rljacob
Copy link
Member

rljacob commented Aug 15, 2023

@sbrus89 did you remove those just to clean up? If we need that case in cime_developers, we could probably add it back.

@sbrus89
Copy link
Contributor

sbrus89 commented Aug 15, 2023

@rljacob, yes. I removed the ww3a grids as a clean-up since we weren't planning to support them. We can add them back in if necessary.

@jasonb5
Copy link
Collaborator Author

jasonb5 commented Aug 15, 2023

@rljacob I'm not sure if it's needed. @jgfouca are we fine to remove this or just replace the grid?

Looks like CESM had it disabled

if utils.get_cime_default_driver() == "nuopc":
skip_tests = [
"SMS_Ln3.T42_T42.S",
"PRE.f19_f19.ADESP_TEST",
"PRE.f19_f19.ADESP",
"DAE.ww3a.ADWAV",
]
and

cime/CIME/tests/base.py

Lines 212 to 215 in 02fad90

if driver == "nuopc" and "cime_developer" in extra_args:
extra_args.append(
" ^SMS_Ln3.T42_T42.S ^PRE.f19_f19.ADESP_TEST ^PRE.f19_f19.ADESP ^DAE.ww3a.ADWAV"
)

@jgfouca
Copy link
Contributor

jgfouca commented Aug 16, 2023

@jasonb5 , we don't have any other DAE tests, so maybe just use a more common grid?

@jgfouca
Copy link
Contributor

jgfouca commented Aug 16, 2023

This raises the question of whether the DAE test type is needed. E3SM has never used it.

@jedwards4b
Copy link
Contributor

We are currently at a stall in the development of that component, however we do have plans to bring it in.

@jgfouca
Copy link
Contributor

jgfouca commented Aug 16, 2023

This will leave DAE untested, but I'm fine with that.

@jgfouca jgfouca merged commit f9f5b78 into master Aug 16, 2023
9 checks passed
@jgfouca jgfouca deleted the remove_test_missing_alias branch August 16, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants