Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu_enabled needs to be true only when gpu is used #4477

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

jedwards4b
Copy link
Contributor

Only set gpu_enabled if gpus are actually used.

Test suite: PFS_Ld5.ne30pg3_ne30pg3_mg17.FLTHIST_v0d.derecho_intel
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #4476

User interface changes?:

Update gh-pages html (Y/N)?:

@jedwards4b jedwards4b self-assigned this Aug 17, 2023
Copy link
Collaborator

@sjsprecious sjsprecious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jedwards4b for finding this issue. Previously I can assign the CPU job to the CPU node correctly by always setting the GPU_TYPE variable at https://github.com/ESMCI/cime/blob/master/CIME/case/case.py#L1588 (i.e., remove the if check). But I tried your fix and it works as well. I do not know which way is better and I will leave it to you to make the decision. Sorry that I did not catch this error earlier.

@jedwards4b jedwards4b merged commit 35bfbae into ESMCI:master Aug 17, 2023
9 checks passed
@jedwards4b jedwards4b deleted the derecho_gpu_enabled_fix branch August 17, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpu_enabled flag
2 participants