Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary kwargs for preprocessors that use iris.cube.Cube.collapsed or iris.cube.Cube.aggregated_by #1851

Closed
schlunma opened this issue Dec 7, 2022 · 2 comments · Fixed by #2191
Labels
enhancement New feature or request

Comments

@schlunma
Copy link
Contributor

schlunma commented Dec 7, 2022

Is your feature request related to a problem? Please describe.

Many iris operators used for collapsing/aggregating allow arbitrary kwargs (see example). We use iris.cube.Cube.collapsed/ iris.cube.Cube.aggregated_by in many preprocessors, so it might make sense to allow arbitrary kwargs in the recipes.

Affected preprocessors:

  • multi_model_statistics
  • ensemble_statistics
  • climate_statistics
  • area_statistics
  • zonal_statistics
  • meridional_statistics
  • volume_statistics
  • axis_statistics
  • hourly_statistics
  • daily_statistics
  • monthly_statistics
  • seasonal_statistics
  • annual_statistics
  • decadal_statistics
@valeriupredoi
Copy link
Contributor

good idea! Do we know which of those are lazy? Also, do we know which are slower/faster? Do we care about performance - well, indirect performance, via iris using internal or external methods, but directly affecting our resources.

@schlunma
Copy link
Contributor Author

schlunma commented Dec 8, 2022

Since basically all of them use iris, I guess that all of them are lazy. There's a list here, but not sure how up-to-date that is.

Regarding performance, I'm not quite sure how that is relevant to this issue, it's just about allowing additional options (which as far as I can tell are not about performance) 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants